-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add border radius tab #220
Conversation
ba670b4
to
bb4446d
Compare
@@ -3,7 +3,7 @@ import React from 'react'; | |||
|
|||
export const TextInputComponent = (props: TextInputProps) => { | |||
return ( | |||
<div style={{width: '100%', maxWidth: 300}}> | |||
<div style={{width: '100%', maxWidth: 300, lineHeight: 0}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not mine) it appeared after rebase)
function createBorderRadiusClassesForCards(values: RadiusValue, forPreview: boolean) { | ||
const cardSizeM = values.l | ||
? `.g-card_size_m { | ||
--_--border-radius: ${values.l}px${forPreview ? ' !important' : ''}; | ||
}\n` | ||
: ''; | ||
const cardSizeL = values.xxl | ||
? `.g-card_size_l { | ||
--_--border-radius: ${values.xxl}px${forPreview ? ' !important' : ''}; | ||
}\n` | ||
: ''; | ||
return cardSizeM && cardSizeL ? '\n' + cardSizeM + cardSizeL : ''; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Так не надо делать, это приватные переменные. Если там border не управляется переменными темы, значит надо это починить
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
сделал ПР в uikit на замену строкового значения константой: gravity-ui/uikit#1682
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
убрал карточки из превью и убрал XXL размер, потому что он нигде не используется:
3aff607
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amje , посмотри, пожалуйста, фикс
3aff607
to
e241564
Compare
feat: create base component for theme page and them sections feat: base types and logic feat: basic palette in colors tab feat: CRUD for basic palette fix: palette tokens order feat: add private colors generator feat: add main settings feat: private color select and advanced brand palette feat: advanced mode switch feat: improve private color editor fix: styles of form row feat: base theme export refactoring: move components to ui and utils to lib chore: fix styles chore: move code to Themes fix: styles and some refactoring feat: i18n feat: add border options feat: Component Preview fix: style for mobile feat: CustomRadius Component feat: refactor types chore: rename options->presets chore: rename RadiusSize->RadiusValue feat: add radius actions feat: connect to theme provider feat: add export styles feat: input type number feat: add icon to button
c12ffc7
to
7f29f29
Compare
* feat: add radius tab feat: create base component for theme page and them sections feat: base types and logic feat: basic palette in colors tab feat: CRUD for basic palette fix: palette tokens order feat: add private colors generator feat: add main settings feat: private color select and advanced brand palette feat: advanced mode switch feat: improve private color editor fix: styles of form row feat: base theme export refactoring: move components to ui and utils to lib chore: fix styles chore: move code to Themes fix: styles and some refactoring feat: i18n feat: add border options feat: Component Preview fix: style for mobile feat: CustomRadius Component feat: refactor types chore: rename options->presets chore: rename RadiusSize->RadiusValue feat: add radius actions feat: connect to theme provider feat: add export styles feat: input type number feat: add icon to button * fix: label row * feat: add common part in exported css * feat: use selectable card component * feat: remove cards and xxl size * feat: use textProps to control style --------- Co-authored-by: Andrey Morozov <[email protected]>
* feat: add radius tab feat: create base component for theme page and them sections feat: base types and logic feat: basic palette in colors tab feat: CRUD for basic palette fix: palette tokens order feat: add private colors generator feat: add main settings feat: private color select and advanced brand palette feat: advanced mode switch feat: improve private color editor fix: styles of form row feat: base theme export refactoring: move components to ui and utils to lib chore: fix styles chore: move code to Themes fix: styles and some refactoring feat: i18n feat: add border options feat: Component Preview fix: style for mobile feat: CustomRadius Component feat: refactor types chore: rename options->presets chore: rename RadiusSize->RadiusValue feat: add radius actions feat: connect to theme provider feat: add export styles feat: input type number feat: add icon to button * fix: label row * feat: add common part in exported css * feat: use selectable card component * feat: remove cards and xxl size * feat: use textProps to control style --------- Co-authored-by: Andrey Morozov <[email protected]>
No description provided.