Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add engine-strict #1601

Merged
merged 5 commits into from
Jun 4, 2024
Merged

chore: add engine-strict #1601

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09544dc
chore: add engine-strict
itwillwork May 21, 2024
100f8d7
fix: patch engines
itwillwork May 21, 2024
e573883
fix: delete engines
itwillwork May 22, 2024
ff43015
ci: change engines
itwillwork May 22, 2024
ce11fe5
Update package.json
itwillwork May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
registry=https://registry.npmjs.org
legacy-peer-deps=true
engine-strict=true
8 changes: 7 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
"version": "6.15.0",
"description": "Gravity UI base styling and components",
"license": "MIT",
"engines": {
"node": "18",
"npm": "10 || 11",
itwillwork marked this conversation as resolved.
Show resolved Hide resolved
"yarn": "Please use npm instead of yarn to install dependencies",
Copy link
Contributor Author

@itwillwork itwillwork May 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example:

image

"pnpm": "Please use npm instead of pnpm to install dependencies"
},
"repository": {
"type": "git",
"url": "https://github.com/gravity-ui/uikit"
Expand Down Expand Up @@ -83,7 +89,7 @@
"lint:prettier:fix": "cross-env prettier --write '**/*.md'",
"lint": "run-p lint:*",
"typecheck": "tsc --noEmit",
"prepublishOnly": "npm run build",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that in the release build package.json does not contain engines section

calling the command again npm pkg delete engines will not cause errors

"prepublishOnly": "npm run build && npm pkg delete engines",
"playwright:install": "playwright install --with-deps",
"playwright": "playwright test --config=playwright/playwright.config.ts",
"playwright:update": "npm run playwright -- -u",
Expand Down
Loading