chore: add engine-strict #1601
Merged
chore: add engine-strict #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itwillwork
commented
May 21, 2024
| "engines": { | ||
| "node": "^18.20.0", | ||
| "npm": "^10.5.0", | ||
| "yarn": "Please use npm instead of yarn to install dependencies", |
itwillwork
commented
May 21, 2024
package.json
Outdated
| @@ -3,6 +3,12 @@ | |||
| "version": "6.15.0", | |||
| "description": "Gravity UI base styling and components", | |||
| "license": "MIT", | |||
| "engines": { | |||
| "node": "^18.20.0", | |||
| "npm": "^10.5.0", | |||
|
Playwright Test Component is ready. |
|
Preview is ready. |
itwillwork
commented
May 22, 2024
| @@ -83,7 +89,7 @@ | |||
| "lint:prettier:fix": "cross-env prettier --write '**/*.md'", | |||
| "lint": "run-p lint:*", | |||
| "typecheck": "tsc --noEmit", | |||
| "prepublishOnly": "npm run build", | |||
There was a problem hiding this comment.
So that in the release build package.json does not contain engines section
calling the command again npm pkg delete engines will not cause errors
amje
requested changes
May 23, 2024
Co-authored-by: Andrey Morozov <[email protected]>
amje
approved these changes
May 23, 2024
amje
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.