Display View button if user can list roles #50872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression that caused users who could list/read roles but NOT edit them to be unable to view the details of the role. This PR will change the text to "view details" if the user can _only_ view and not edit. The edit button in the role editor already has logic to prevent and tell the user they do not have permissions to edit, so no further changes need to be made there.
avatus
added
backport-required
no-changelog
|
This seems fine but also introduces a new side effect, if someone was to have edit permissions but not view permissions (for whatever reason), the button would now be hidden. Not sure how much that matters |
i thought about this, but they wont be able to list/view any roles to begin with, so there isnt even a spot for the edit button to exist. so i dont think its something we need to worry about |
ryanclark
approved these changes
Jan 8, 2025
flyinghermit
approved these changes
Jan 8, 2025
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression that caused users who could list/read roles but NOT edit them to be unable to view the details of the role.
This PR will change the text to "view details" if the user can only view and not edit.
The edit button in the role editor already has logic to prevent and tell the user they do not have permissions to edit, so no further changes need to be made there.
fixes #50767