Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Display View button if user can list roles #50889

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

avatus
Copy link
Contributor

@avatus avatus commented Jan 8, 2025

Backport #50872 to branch/v16

This fixes a regression that caused users who could list/read roles but
NOT edit them to be unable to view the details of the role.

This PR will change the text to "view details" if the user can _only_
view and not edit.

The edit button in the role editor already has logic to prevent and tell
the user they do not have permissions to edit, so no further changes
need to be made there.
@avatus avatus added the no-changelog Indicates that a PR does not require a changelog entry label Jan 8, 2025
@avatus avatus enabled auto-merge January 8, 2025 20:53
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from ryanclark January 9, 2025 18:19
@avatus avatus added this pull request to the merge queue Jan 9, 2025
Merged via the queue into branch/v16 with commit 36b85dd Jan 9, 2025
41 of 42 checks passed
@avatus avatus deleted the bot/backport-50872-branch/v16 branch January 9, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants