In the otelcol docs, refer to either server or client TLS config. #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
approved these changes
Apr 16, 2024
docs/sources/shared/reference/components/otelcol-tls-server-block.md
Outdated
Show resolved
Hide resolved
tpaschalis
approved these changes
Apr 19, 2024
ptodev
commented
Apr 22, 2024
docs/sources/shared/reference/components/otelcol-tls-server-block.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell
added
the
type/docs
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
* In the docs, refer to either server or client TLS config. * Apply suggestions from code review Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit cf30906)
tpaschalis
pushed a commit
that referenced
this pull request
Apr 26, 2024
…) (#686) Co-authored-by: Paulin Todev <[email protected]>
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
…afana#592) * In the docs, refer to either server or client TLS config. * Apply suggestions from code review Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TLS arguments for clients and servers differ. However, the docs are currently only showing the attributes for clients.
This PR renames the current TLS argument to "client arguments", and introduces "server" arguments. It also changes all references in docs to use the appropriate arguments.