Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static/metrics): migrate default WAL directory to data-alloy #571

Merged
merged 4 commits into from
Apr 19, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -29,10 +29,6 @@ Main (unreleased)

- Fixed issue with defaults for Beyla component not being applied correctly. (marctc)

### Other changes

- Migrate static mode's default WAL directory from `data-agent` to `data-alloy`. (@hainenber)

v1.0.0 (2024-04-09)
-------------------

14 changes: 8 additions & 6 deletions internal/static/metrics/agent.go
Original file line number Diff line number Diff line change
@@ -19,12 +19,14 @@ import (
var DefaultConfig = Config{
Global: instance.DefaultGlobalConfig,
InstanceRestartBackoff: 5 * time.Second,
WALDir: "data-alloy/",
WALCleanupAge: 12 * time.Hour,
WALCleanupPeriod: 30 * time.Minute,
ServiceConfig: cluster.DefaultConfig,
ServiceClientConfig: client.DefaultConfig,
InstanceMode: instance.DefaultMode,
// The following legacy WALDir path is intetionally kept for config conversion from static to Alloy.
// Consult Alloy maintainers for changes.
WALDir: "data-alloy/",
Copy link
Member

@tpaschalis tpaschalis Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this line as data-agent like Robert said in his previous comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot this one. Done in the HEAD commit :D

WALCleanupAge: 12 * time.Hour,
WALCleanupPeriod: 30 * time.Minute,
ServiceConfig: cluster.DefaultConfig,
ServiceClientConfig: client.DefaultConfig,
InstanceMode: instance.DefaultMode,
}

// Config defines the configuration for the entire set of Prometheus client