feat(static/metrics): migrate default WAL directory to data-alloy
#571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
reviewed
Apr 14, 2024
internal/static/metrics/agent.go
Outdated
| @@ -19,7 +19,7 @@ import ( | |||
| var DefaultConfig = Config{ | |||
| Global: instance.DefaultGlobalConfig, | |||
| InstanceRestartBackoff: 5 * time.Second, | |||
| WALDir: "data-agent/", | |||
| WALDir: "data-alloy/", | |||
There was a problem hiding this comment.
This one is intentional; internal/static is kept around for the config converters from static -> Alloy, and so we want to keep its default configuration the same, where it does write to data-agent/ by default :)
There was a problem hiding this comment.
Maybe adding a comment instead would be useful here so others can more easily understand why it’s not renamed
Signed-off-by: hainenber <[email protected]>
… legacy `data-agent` + remove CHANGELOG entry Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
refactor-leftover-data-agent-ref
branch
from
5579e4e to
249350c
Compare
tpaschalis
reviewed
Apr 17, 2024
internal/static/metrics/agent.go
Outdated
Comment on lines
22
to
24
| // The following legacy WALDir path is intetionally kept for config conversion from static to Alloy. | ||
| // Consult Alloy maintainers for changes. | ||
| WALDir: "data-alloy/", |
There was a problem hiding this comment.
Can we keep this line as data-agent like Robert said in his previous comment?
There was a problem hiding this comment.
Oops, forgot this one. Done in the HEAD commit :D
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
tpaschalis
approved these changes
Apr 19, 2024
rfratto
added
the
backport-to-agent:no
hainenber
added a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
Signed-off-by: hainenber <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I notice that there are a few places where
data-agentis still referenced despite the default directory for storage is nowdata-alloy.Which issue(s) this PR fixes
Notes to the Reviewer
I have a hunch that these refs are being intentionally kept for other purposes. If that's the case, kindly help closing the PR as I don't have further context :D
PR Checklist