Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wal doc #1917

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Update wal doc #1917

merged 4 commits into from
Nov 18, 2024

Conversation

mattdurham
Copy link
Collaborator

Update WAL doc and importantly remove reference to password_file since we dont support it, it should be handled by local.file or other functionality.

`parallelism` | `uint` | How many parallel batches to write. | 10 | no
`external_labels` | `map(string)` | Labels to add to metrics sent over the network. | | no
Name | Type | Description | Default | Required
----------------------|------------------------------------------------------|-----------------------------------------------------------------|---------|----------
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional change here is using the word long in retry_backoff and flush_interval

@mattdurham mattdurham marked this pull request as ready for review October 17, 2024 18:33
@mattdurham mattdurham added the type/docs Docs Squad label across all Grafana Labs repos label Oct 17, 2024
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one missing column for the data type... otherwise looks good to me.

Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@mattdurham mattdurham merged commit 9c04d73 into main Nov 18, 2024
18 checks passed
@mattdurham mattdurham deleted the cleanup_wal_doc branch November 18, 2024 15:04
vaxvms pushed a commit to vaxvms/alloy that referenced this pull request Nov 20, 2024
* Docs changes.

* Clean up tables

* True up the documentation with the code.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age needs-attention type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants