feat: add prometheus.write.queue bearer token auth #1914
Conversation
|
|
freak12techno
requested review from
clayton-cornell and
a team
as code owners
freak12techno
force-pushed
the
add-prometheus-write-queue-bearer-token-auth
branch
from
b9a5cb3 to
2867c13
Compare
|
@mattdurham mind taking a look? |
|
Would like to see a validation so that you cannot set both bearer token and basic auth, with a test to catch that. Otherwise looks good! |
| `url` | `string` | Full URL to send metrics to. | | yes | ||
| `bearer_token` | `secret` | Bearer token to authenticate with. | | no | ||
| `write_timeout` | `duration` | Timeout for requests made to the URL. | `"30s"` | no | ||
| `retry_backoff` | `duration` | How often to wait between retries. | `1s` | no |
There was a problem hiding this comment.
How often or how long?
There was a problem hiding this comment.
@clayton-cornell I dont think he changed most of these, I think adding bearer_token triggered them to look different. I can create a separate PR for these doc comments related to backoff and flush interval.
There was a problem hiding this comment.
Yeah I didn't, it's my IDE that apparently tried to format it, only thing I changed is adding this line and also fixing the typo (trigger -> triggered) in another one.
There was a problem hiding this comment.
I might change it here as well though if you prefer
| `retry_backoff` | `duration` | How often to wait between retries. | `1s` | no | ||
| `max_retry_attempts` | Maximum number of retries before dropping the batch. | `0` | no | ||
| `batch_count` | `uint` | How many series to queue in each queue. | `1000` | no | ||
| `flush_interval` | `duration` | How often to wait until sending if `batch_count` is not triggered. | `1s` | no |
There was a problem hiding this comment.
Same question.. often or long? If we say "how often" it doesn't make sense to me.. Wait 6 times (would be how often) vs Wait 2 minutes (would be how long).
clayton-cornell
added
the
type/docs
|
@freak12techno I will follow up on the docs items in #1917 , has long as @clayton-cornell is good with the bearer token text. |
|
okay @mattdurham I didn't get a chance to add tests + validations before this got merged :( should I make another PR adding it, or would you add it in your PR? |
freak12techno
deleted the
add-prometheus-write-queue-bearer-token-auth
branch
|
I can handle it, I jumped the gun on it |
PR Description
Which issue(s) this PR fixes
Fixes #1913
Notes to the Reviewer
PR Checklist