-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support vertical band connection between top and bottom axes with independent scales #459
Open
sehilyi
wants to merge
34
commits into
main
Choose a base branch
from
sehilyi/two-independent-x-axes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehilyi
force-pushed
the
sehilyi/two-independent-x-axes
branch
2 times, most recently
from
August 27, 2021 17:38
890e0b5
to
5940b38
Compare
sehilyi
force-pushed
the
sehilyi/two-independent-x-axes
branch
from
August 28, 2021 23:27
bacefc6
to
f0c00c8
Compare
Closed
1 task
sehilyi
force-pushed
the
sehilyi/two-independent-x-axes
branch
from
August 30, 2021 15:22
5e5e883
to
19b5e69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates (Draft)
Added
yDomain
An open issue is that since we do not distort the scale between x and y axes,
yDomain
is dependent onxDomain
, and the actual domain of the y-axis is adjusted internally. For example, showing chromosome 1 on the x-axis and showing the entire genome on the y-axis is not possible. Instead, the y-axis uses the same scale of the x-axis and zooms to the center position of the originalyDomain
.Renamed
linkingId
toxLinkingId
and addedyLinkingId
Grammar-wise, the differentiation of the x and y axes allows more flexibility for linking, e.g., cross-axes linking.
Ability to use
yScale
for the second x-axis in the"gosling-2d-track"
This applies when
betweenLink
mark is used and differentxLinkingId
s are applied betweenx
andx1
.Design Decisions
To Do
Screenshots
Experimental
Based on an ideogram.js example
Dependent on higlass/higlass#1042
Fix #160