feat: allow parallel and serial arrangements of multiple circular views with different domains #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR allows using different domains among multiple circular views if they are arranged in parallel or serial. Previously, due to technical limitations, such circular views were not able to show different domains.
The main reason was that to show circular views inside the same rectangular area, such views had to be assigned to the same HiGlass view (i.e.,
center.combined
). Since a HiGlass view only has a single domain, this resulted in forcing to show the identical domain across such views.Given that
react-grid-layout
will allow overlaps (allowOverlap: true
) in the next release, we can render views in separate RGL's views and superpose them (screenshot).Example
Parallel
Multiple ideograms that show different chromosomes are arranged in
parallel
.Serial
Two chromosomes, chr1 and chr2, are juxtaposed and mirrored (
serial
arrangement).To-Do
allowOverlap
of RGL is not released yet, this PR uses manually built RGL and HiGlass packages. Once the new version of RGL is released, we can upgrade RGL in HiGlass and include anallowOverlap
prop in the HiGlass view config.Open Issues
Fix #203