Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow parallel and serial arrangements of multiple circular views with different domains #422

Closed
wants to merge 2 commits into from

Conversation

sehilyi
Copy link
Member

@sehilyi sehilyi commented Jul 6, 2021

Overview

This PR allows using different domains among multiple circular views if they are arranged in parallel or serial. Previously, due to technical limitations, such circular views were not able to show different domains.

The main reason was that to show circular views inside the same rectangular area, such views had to be assigned to the same HiGlass view (i.e., center.combined). Since a HiGlass view only has a single domain, this resulted in forcing to show the identical domain across such views.

Given that react-grid-layout will allow overlaps (allowOverlap: true) in the next release, we can render views in separate RGL's views and superpose them (screenshot).

Example

Parallel

Multiple ideograms that show different chromosomes are arranged in parallel.

gosling-visualization

Serial

Two chromosomes, chr1 and chr2, are juxtaposed and mirrored (serial arrangement).
Screen Shot 2021-07-06 at 11 55 53 AM

To-Do

  • Since the allowOverlap of RGL is not released yet, this PR uses manually built RGL and HiGlass packages. Once the new version of RGL is released, we can upgrade RGL in HiGlass and include an allowOverlap prop in the HiGlass view config.

Open Issues

Fix #203

@sehilyi sehilyi changed the title feat: allow parallel and serial arrangements of multiple circular views with different domains feat: allow parallel and serial arrangements of multiple circular views with different domains Aug 13, 2021
@sehilyi
Copy link
Member Author

sehilyi commented Aug 29, 2021

This has been merged to another PR, #459.

@sehilyi sehilyi closed this Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow showing different genomic intervals in parallelized and serialized circular views
1 participant