Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use top most view controller on iOS #818

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

jjliu15
Copy link
Collaborator

@jjliu15 jjliu15 commented Apr 13, 2023

Description

Fixes an issue in the add to app case for iOS. The rootViewController is presenting another VC which causes GMA to fail to show the interstitial.

Related Issues

#700

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jjliu15 jjliu15 requested a review from luo86 April 13, 2023 18:29
@jjliu15 jjliu15 merged commit 4f31a10 into googleads:main Apr 17, 2023
@jjliu15 jjliu15 deleted the add_to_app_ios_issue branch April 17, 2023 21:30
@renis1235
Copy link

Hello, this bug is still present.
See #845
and #700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants