Fix rootViewController problems after SceneDelegate changes #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidHDJ
changed the title
jjliu15
reviewed
Feb 27, 2023
| @@ -355,7 +355,7 @@ - (instancetype)initWithAdUnitId:(NSString *_Nonnull)adUnitId | |||
| _bannerView = [[GADBannerView alloc] initWithAdSize:size.size]; | |||
| _bannerView.adUnitID = adUnitId; | |||
| self.adId = adId; | |||
| self.bannerView.rootViewController = rootViewController; | |||
| self.bannerView.rootViewController = self; | |||
There was a problem hiding this comment.
This will break the more general use case, since FLTBannerAd is not a UIViewController. The main issue is that the plugin always uses UIApplication.sharedApplication.delegate.window.rootViewController as the rootViewController for all its ad views.
To fix this issue we'll probably need a new API that lets you override the rootViewController.
Could you update https://github.com/googleads/googleads-mobile-flutter/pull/768/files with a minimally reproducible sample?
|
Can you check if #818 fixes this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#767
Description
When you want to use this package with other packages which needs a SceneDelegate you get the error
You must set the rootViewController property of <GADInternalBannerView: 0x7fd71ad12be0; frame = (0 0; 320 50); clipsToBounds = YES; autoresize = W+H; backgroundColor = UIExtendedGrayColorSpace 0 0; layer = <CALayer: 0x60000311d600>> before loading a request..Changing the rootViewController to self fix this problem
Related Issues
#767
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?