[googleapis_auth] Add support for non-Google OAuth providers #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How 'bout a changelog entry? |
|
Done. Wasn't sure about versioning, but a minor bump seemed appropriate. |
|
HOLY COW! That is some DEEP injection. 🙃 |
kevmoo
approved these changes
Feb 27, 2024
|
published! |
|
Awesome! Thanks for the help and quick attention |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows consumers of this package to provide their own authorization and token endpoints for use with non-Google OAuth providers.
This is accomplished through the introduction of an
AuthEndpointsclass, which has properties for these two URIs. There is a single concrete subclass ofAuthEndpointsin this package for the Google values (GoogleAuthEndpoints). Consumers wishing to support other providers should subclassAuthEndpointsand provide the appropriate URIs for the provider they wish to support.Most of the exported APIs now accept an
AuthEndpointsparameter whose default value isGoogleAuthEndpoints.This change should be non-breaking and transparent to existing users.
Fixes #596
Note: there are some added tests in
auth_code_test.dartthat aren't directly relevant to this PR. They were added in Shorebird's fork to satisfy our coverage checks. Happy to remove them to make this PR cleaner/more focused.