Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow support for non-Google auth providers #596

Closed
bryanoltman opened this issue Feb 26, 2024 · 2 comments · Fixed by #597
Closed

Allow support for non-Google auth providers #596

bryanoltman opened this issue Feb 26, 2024 · 2 comments · Fixed by #597

Comments

@bryanoltman
Copy link
Contributor

Because the "get code, exchange code for token" flow is very standard, it would be nice if the googleapis_auth package could be extended to support other OAuth providers. This should just require the ability to make two URIs configurable: the auth endpoint and the token endpoint (these currently are hardcoded in the known URIs file). We've forked this package in shorebird and made this change, and would be happy to help upstream if there is interest.

Our fork: https://github.com/shorebirdtech/shorebird/tree/main/third_party/googleapis_auth

@kevmoo
Copy link
Collaborator

kevmoo commented Feb 26, 2024

If it's a clean, non-breaking PR send away!

If it's not clean or requires breaks, let's chat.

@bryanoltman
Copy link
Contributor Author

Aiming for clean and non breaking with #597 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants