SCons: Warn when passing invalid options #99690
Open
+52
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main difference between this and the salvaged PR is an attempt to keep the workflow as integrated with SCons tools as possible (within the extent of the original scope). Also, because support for profiles passing unknown varibles will be added to SCons in the future1, the salvaged profile logic is now wrapped in a conditional that excludes future releases. I also ensured the SCons order-of-operations is respected; that is, command line arguments will override profile arguments. Finally, I adopted the multi-profile format used in #91794
Footnotes
https://github.com/SCons/scons/pull/4653 ↩