-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCons: Warn when passing unknown variables #91213
Conversation
40d6019
to
646757a
Compare
Double-checked to make sure the regressions from #56551 are no longer applicable. The mono-stuff is no longer relevant as that logic appears to have been removed entirely, or otherwise relocated to not use the argument system. The only regression I could replicate was the |
646757a
to
ab6ff95
Compare
Just curious with which SCons version did you check it? If you still can run it without any issues... |
Reson why I had asked is that I tried to run your PR and it worked. With exception to the fact it also printed SCons internals 😅 something like this but with much more crap from SCons...
I've tried both 4.8.1 and 3.1.2 (out current minimal 😅) |
Don't mind 😅. Turned out that we polluted unknown variables by ourselves when do |
Superseded by #99690 |
Lifted largely from godot-cpp's implementation1, albeit with formatting tweaked to be more in-line with recent SConstruct adjustments.
Example output:
Footnotes
https://github.com/godotengine/godot-cpp/blob/e23b117ac32fdbeb0920f234e193e6d31307c0ad/SConstruct#L41-L46 ↩