Access files using UTF-8 encoding #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animations with no channels are invalid in GLTF
|
Do you think it's possible to use only std from c++? I'm curious. |
|
its 'possible' to using std but that would be a lot more messy, boost::nowide is designed specifically as a drop in replacement for std to solve UTF-8 problems, especially on Windows. and nowide is integrated with boost::filesystem which is already in use here. |
fire
approved these changes
Apr 27, 2024
There was a problem hiding this comment.
It looks good to me, but can you squash to one commit. I'll see if I can get @bruvzg to take a look.
You also stacked Skip empty animations ontop of this pr. Would prefer for them to be separate.
|
oh thank you! I didn't find time to fix this :-) |
lyuma
approved these changes
Apr 28, 2024
lyuma
approved these changes
Apr 28, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file names in FBX are encoded as UTF-8 and mustbe accessed properly, especially on Windows.