-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AddressDomain
for MayPointTo
and ReachableFrom
queries
#1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Simmo Saan <[email protected]>
Co-authored-by: Simmo Saan <[email protected]>
Co-authored-by: Simmo Saan <[email protected]>
Co-authored-by: Simmo Saan <[email protected]>
Co-authored-by: Simmo Saan <[email protected]>
Co-authored-by: Simmo Saan <[email protected]>
karoliineh
added
cleanup
Refactoring, clean-up
type-safety
Type-safety improvements
precision
labels
Aug 22, 2023
Co-authored-by: Simmo Saan <[email protected]>
karoliineh
changed the title
Use
Use Aug 29, 2023
AddressDomain
for queriesAddressDomain
for MayPointTo
and ReachableFrom
queries
5 tasks
Required to fix Promela extraction tests.
@michael-schwarz Do you intend to review this again or was that all? |
It all seems reasonable at first glance, anything you would like me to look into in particular? |
Not really, I just wasn't sure since you left one small comment previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change
MayPointTo
andReachableFrom
query result fromLS
toAddressDomain
. This has numerous benefits:AD
→LS
→AD
/Set (Varinfo)
/....LS
had two different top representations (one forToppedSet
entirely and another whendummyFundec.svar
was a member). The former allows no known pointers along with unknown pointer, the latter is easy to forget/not know about.AD
has only one explicit representation by containingUnknownPtr
.NullPtr
s are not implicitly excluded from query results, allowing other analyses to know about them at all. For example, now we warn about unlockingNULL
pointer.ID
indices which were dropped (if not definite) when converting toexp
indices inLS
. Now interval, etc offsets can be seen by other analyses.Fix unsoundness in analyses which previously forgot to check for
dummyFundec
in query results: relation, fileUse, poisonVariables, uninit, var_eq (inspecial
).TODO
MayPointToA
andReachableFromA
intaintPartialContexts
.LS
.Address
/Mval
/Offset
conversion functions.ls
→ad
,lv
→ addr.