Fix NULL and unknown pointer handling in MayPointTo and ReachableFrom for race analysis
#1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
added
the
pr-dependency
karoliineh
approved these changes
Sep 20, 2023
michael-schwarz
approved these changes
Sep 23, 2023
sim642
removed
the
pr-dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This on top of #1174 because that's where #1175 first appeared.
This isn't a complete fix for #1175 but enough to fix various combinations of
NULLand unknown pointers in theMayPointToandReachableFromqueries done by race analysis.Changes
ReachableFromunknown pointer handling which was accidentally removed in UseAddressDomainforMayPointToandReachableFromqueries #1142.Intvalues toAddressfor the two queries. This is needed becauseNULLyields a zero integer constant.