feat: add r/sys/params + params genesis support

examples/gno.land/r/gov/dao/prop2_filetest.gno

@@ -18,11 +18,8 @@ func init() {
 	}
 
 	mExec := govdao.NewPropExecutor(membersFn)
-
 	comment := "adding someone to vote"
-
 	id := govdao.Propose(comment, mExec)
-
 	govdao.ExecuteProposal(id)
 
 	executor := proposal.NewCtxExecutor(func(ctx context.Context) error {

examples/gno.land/r/gov/dao/prop3_filetest.gno

@@ -0,0 +1,95 @@
+package main
+
+import (
+	"std"
+
+	govdao "gno.land/r/gov/dao"
+	"gno.land/r/sys/params"
+)
+
+func init() {
+	{ // prop0
+		membersFn := func() []std.Address {
+			return []std.Address{
+				std.Address("g1wymu47drhr0kuq2098m792lytgtj2nyx77yrsm"),
+			}
+		}
+		mExec := govdao.NewPropExecutor(membersFn)
+		comment := "adding someone to vote"
+		id := govdao.Propose(comment, mExec)
+		govdao.ExecuteProposal(id)
+	}
+
+	{ // prop1
+		mExec := params.NewStringPropExecutor("prop1.string", "value1")
+		comment := "setting prop1.string param"
+		id := govdao.Propose(comment, mExec)
+	}
+
+	{ // prop2
+		mExec := params.NewInt64PropExecutor("prop2.int64", 12345)
+		comment := "setting prop2.int64 param"
+		id := govdao.Propose(comment, mExec)
+	}
+}
+
+func main() {
+	println("--")
+	println(govdao.Render(""))
+	println("--")
+	println(govdao.Render("1"))
+	println("--")
+	govdao.VoteOnProposal(1, "YES")
+	println("--")
+	println(govdao.Render("1"))
+	println("--")
+	govdao.ExecuteProposal(1)
+	println("--")
+	println(govdao.Render("1"))
+}
+
+// Events:
+// [{"type":"set","attrs":[{"key":"k","value":"prop1.string"}],"pkg_path":"gno.land/r/sys/params","func":""}]
+
+// Output:
+// --
+// - [0](/r/gov/dao:0) - adding someone to vote (**succeeded**)(by g1wymu47drhr0kuq2098m792lytgtj2nyx77yrsm)
+// - [1](/r/gov/dao:1) - setting prop1.string param (**active**)(by g1wymu47drhr0kuq2098m792lytgtj2nyx77yrsm)
+// - [2](/r/gov/dao:2) - setting prop2.int64 param (**active**)(by g1wymu47drhr0kuq2098m792lytgtj2nyx77yrsm)
+//
+// --
+// # Prop #1
+//
+// setting prop1.string param
+//
+// Status: active
+//
+// Voting status: YES: 0, NO: 0, percent: 0, members: 1
+//
+// Author: g1wymu47drhr0kuq2098m792lytgtj2nyx77yrsm
+//
+//
+// --
+// --
+// # Prop #1
+//
+// setting prop1.string param
+//
+// Status: accepted
+//
+// Voting status: YES: 1, NO: 0, percent: 100, members: 1
+//
+// Author: g1wymu47drhr0kuq2098m792lytgtj2nyx77yrsm
+//
+//
+// --
+// --
+// # Prop #1
+//
+// setting prop1.string param
+//
+// Status: succeeded
+//
+// Voting status: YES: 1, NO: 0, percent: 100, members: 1
+//
+// Author: g1wymu47drhr0kuq2098m792lytgtj2nyx77yrsm

examples/gno.land/r/sys/params/gno.mod

@@ -0,0 +1,3 @@
+module gno.land/r/sys/params
+
+require gno.land/p/gov/proposal v0.0.0-latest

examples/gno.land/r/sys/params/params.gno

@@ -0,0 +1,43 @@
+package params
+
+import (
+	"std"
+
+	"gno.land/p/gov/proposal"
+)
+
+const daoPkgPath = "gno.land/r/gov/dao"
+
+func NewStringPropExecutor(key string, value string) proposal.Executor {
+	return newPropExecutor(key, func() { std.SetParamString(key, value) })
+}
+
+func NewInt64PropExecutor(key string, value int64) proposal.Executor {
+	return newPropExecutor(key, func() { std.SetParamInt64(key, value) })
+}
+
+func NewUint64PropExecutor(key string, value uint64) proposal.Executor {
+	return newPropExecutor(key, func() { std.SetParamUint64(key, value) })
+}
+
+func NewBoolPropExecutor(key string, value bool) proposal.Executor {
+	return newPropExecutor(key, func() { std.SetParamBool(key, value) })
+}
+
+func NewBytesPropExecutor(key string, value []byte) proposal.Executor {
+	return newPropExecutor(key, func() { std.SetParamBytes(key, value) })
+}
+
+func newPropExecutor(key string, fn func()) proposal.Executor {
+	callback := func() error {
+		if std.PrevRealm().PkgPath() != daoPkgPath {
+			panic("should be executed from govdao")
+		}
+		std.Emit("set",
+			"k", key,
+		)
+		fn()
+		return nil
+	}
+	return proposal.NewExecutor(callback)
+}

gno.land/cmd/gnoland/testdata/genesis_params.txtar

@@ -0,0 +1,14 @@
+# test for https://github.com/gnolang/gno/pull/3003
+
+gnoland start
+
+gnokey query params/vm/gno.land/r/sys/params.test.foo.string
+stdout 'data: "bar"$'
+gnokey query params/vm/gno.land/r/sys/params.test.foo.int64
+stdout 'data: "-1337"'
+gnokey query params/vm/gno.land/r/sys/params.test.foo.uint64
+stdout 'data: "42"'
+gnokey query params/vm/gno.land/r/sys/params.test.foo.bool
+stdout 'data: true'
+# XXX: bytes
+

gno.land/genesis/genesis_params.toml

@@ -0,0 +1,29 @@
+
+## gno.land
+["gno.land/r/sys/params.sys"]
+  users_pkgpath.string = "gno.land/r/sys/users" # if empty, no namespace support.
+  # TODO: validators_pkgpath.string = "gno.land/r/sys/validators"
+  # TODO: rewards_pkgpath.string = "gno.land/r/sys/rewards"
+  # TODO: token_lock.bool = true
+
+## gnovm
+["gno.land/r/sys/params.vm"]
+  # TODO: chain_domain.string = "gno.land"
+  # TODO: max_gas.int64 = 100_000_000
+  # TODO: chain_tz.string = "UTC"
+  # TODO: default_storage_allowance.string = ""
+
+## tm2
+["gno.land/r/sys/params.tm2"]
+
+## misc
+["gno.land/r/sys/params.mix"]
+
+## testing
+# do not remove these lines. they are needed for a txtar integration test.
+["gno.land/r/sys/params.test"]
+  foo.string = "bar"
+  foo.int64 = -1337
+  foo.uint64 = 42
+  foo.bool = true
+  #foo.bytes = todo

gno.land/pkg/gnoland/app.go

@@ -290,7 +290,7 @@ func (cfg InitChainerConfig) loadAppState(ctx sdk.Context, appState any) ([]abci
 		return nil, fmt.Errorf("invalid AppState of type %T", appState)
 	}
 
-	// Parse and set genesis state balances
+	// Apply genesis balances.
 	for _, bal := range state.Balances {
 		acc := cfg.acctKpr.NewAccountWithAddress(ctx, bal.Address)
 		cfg.acctKpr.SetAccount(ctx, acc)
@@ -300,6 +300,12 @@ func (cfg InitChainerConfig) loadAppState(ctx sdk.Context, appState any) ([]abci
 		}
 	}
 
+	// Apply genesis params.
+	for _, param := range state.Params {
+		param.Register(ctx, cfg.paramsKpr)
+	}
+
+	// Replay genesis txs.
 	txResponses := make([]abci.ResponseDeliverTx, 0, len(state.Txs))
 	// Run genesis txs
 	for _, tx := range state.Txs {

gno.land/pkg/gnoland/app_test.go

@@ -63,6 +63,13 @@ func TestNewAppWithOptions(t *testing.T) {
 					Signatures: []std.Signature{{}}, // one empty signature
 				},
 			},
+			Params: []Param{
+				{key: "foo", kind: "string", value: "hello"},
+				{key: "foo", kind: "int64", value: int64(-42)},
+				{key: "foo", kind: "uint64", value: uint64(1337)},
+				{key: "foo", kind: "bool", value: true},
+				{key: "foo", kind: "bytes", value: []byte{0x48, 0x69, 0x21}},
+			},
 		},
 	})
 	require.True(t, resp.IsOK(), "InitChain response: %v", resp)
@@ -84,6 +91,27 @@ func TestNewAppWithOptions(t *testing.T) {
 		Tx:          tx,
 	})
 	require.True(t, dtxResp.IsOK(), "DeliverTx response: %v", dtxResp)
+
+	cres := bapp.Commit()
+	require.NotNil(t, cres)
+
+	tcs := []struct {
+		path        string
+		expectedVal string
+	}{
+		{"params/vm/foo.string", `"hello"`},
+		{"params/vm/foo.int64", `"-42"`},
+		{"params/vm/foo.uint64", `"1337"`},
+		{"params/vm/foo.bool", `true`},
+		{"params/vm/foo.bytes", `"SGkh"`}, // XXX: make this test more readable
+	}
+	for _, tc := range tcs {
+		qres := bapp.Query(abci.RequestQuery{
+			Path: tc.path,
+		})
+		require.True(t, qres.IsOK())
+		assert.Equal(t, qres.Data, []byte(tc.expectedVal))
+	}
 }
 
 func TestNewAppWithOptions_ErrNoDB(t *testing.T) {

gno.land/pkg/gnoland/genesis.go

@@ -13,6 +13,7 @@
 	"github.com/gnolang/gno/tm2/pkg/crypto"
 	osm "github.com/gnolang/gno/tm2/pkg/os"
 	"github.com/gnolang/gno/tm2/pkg/std"
+	"github.com/pelletier/go-toml"
 )
 
 // LoadGenesisBalancesFile loads genesis balances from the provided file path.
@@ -58,6 +59,42 @@
 	return balances, nil
 }
 
+// LoadGenesisParamsFile loads genesis params from the provided file path.
+func LoadGenesisParamsFile(path string) ([]Param, error) {
+	// each param is in the form: key.kind=value
+	content := osm.MustReadFile(path)
+
+	m := map[string] /*category*/ map[string] /*key*/ map[string] /*kind*/ interface{} /*value*/ {}
+	err := toml.Unmarshal(content, &m)
+	if err != nil {
+		return nil, err
+	}
+
+	params := make([]Param, 0)
+	for category, keys := range m {
+		for key, kinds := range keys {
+			for kind, val := range kinds {
+				param := Param{
+					key:  category + "." + key,
+					kind: kind,
+				}
+				switch kind {
+				case "uint64": // toml
+					param.value = uint64(val.(int64))
+				default:
+					param.value = val
+				}
+				if err := param.Verify(); err != nil {
+					return nil, err
+				}
+				params = append(params, param)
+			}
+		}
+	}
+
+	return params, nil
+}
+
 // LoadGenesisTxsFile loads genesis transactions from the provided file path.
 // XXX: Improve the way we generate and load this file
 func LoadGenesisTxsFile(path string, chainID string, genesisRemote string) ([]std.Tx, error) {