Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add r/sys/params + params genesis support #3003

Merged
merged 90 commits into from
Nov 12, 2024
Merged

feat: add r/sys/params + params genesis support #3003

merged 90 commits into from
Nov 12, 2024

Conversation

moul
Copy link
Member

@moul moul commented Oct 22, 2024 •
edited
Loading

Depends on #2920
Depends on #3003 (cherry-picked)
Blocking #2911

moul added 28 commits October 11, 2024 09:47
@moul
feat(tm2/sdk/params): initial version
b930513
@moul
feat: inject ParamsKeeper in VMKeeper
602245d 
Signed-off-by: moul <[email protected]>
@moul
feat: configure params in gno.land
783a044 
Signed-off-by: moul <[email protected]>
@moul
Merge branch 'master' into dev/moul/mod-params
072aa12
@moul
chore: remove unused param
89e046c 
Signed-off-by: moul <[email protected]>
@moul
chore: disable --flag-config-path
5d1e36a 
Signed-off-by: moul <[email protected]>
@moul
Merge branch 'master' into dev/moul/mod-params
e5a869d
@moul
chore: fixup
581ef26 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
a39d172 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
0342b61 
Signed-off-by: moul <[email protected]>
@moul
chore: remove vmkeeper.maxcycles
dd8ca08 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
e573b6a 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
993d213 
Signed-off-by: moul <[email protected]>
@moul
Merge branch 'dev/moul/remove-max-cycles' into dev/moul/mod-params
ee8c778
@moul
chore: fixup
95384ae 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
a4608eb 
Signed-off-by: moul <[email protected]>
@moul
chore: rename config -> param
9f18bad 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
5ba066e 
Signed-off-by: moul <[email protected]>
@moul
Merge remote-tracking branch 'origin/master' into dev/moul/mod-params
4e097fc
@moul
chore: ignore generated files from codecov
5260059 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
309806f 
Signed-off-by: moul <[email protected]>
@moul
Merge branch 'master' into dev/moul/mod-params
911c27f
@moul
Merge remote-tracking branch 'origin/master' into dev/moul/mod-params
94cf1a4
@moul
chore: fixup
604466c 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
8c5b00a 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
4a1c0bb 
Signed-off-by: moul <[email protected]>
@moul
chore: fixup
86b4fbd 
Signed-off-by: moul <[email protected]>
@moul
feat: add r/sys/params + params genesis support
61839a8 
Signed-off-by: moul <[email protected]>
@moul moul self-assigned this Oct 22, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Oct 22, 2024
@moul moul mentioned this pull request Nov 7, 2024
Merged
@gfanton gfanton mentioned this pull request Nov 8, 2024
Closed
6 tasks
@moul moul mentioned this pull request Nov 8, 2024
Closed
@moul moul assigned zivkovicmilos and unassigned moul Nov 8, 2024
thehowl added a commit that referenced this pull request Nov 8, 2024
@moul @thehowl
test(ci): coverpkg=gno.land/... for txtar tests (#3088)
da79c84 
Note: I'm uncertain about what will happen after the merge.

Fixes #3085 
Addresses #3003

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: Morgan <[email protected]>
zivkovicmilos
zivkovicmilos approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good 💯

I've left a few questions to better understand the dynamics between the Params Keeper and the std API 🙏

gno.land/cmd/gnoland/testdata/genesis_params.txtar Show resolved Hide resolved
gno.land/pkg/gnoland/genesis.go Outdated Show resolved Hide resolved
gno.land/pkg/gnoland/genesis.go Show resolved Hide resolved
gno.land/pkg/gnoland/param.go Show resolved Hide resolved
gno.land/pkg/gnoland/param.go Show resolved Hide resolved
gno.land/pkg/gnoland/param.go Outdated Show resolved Hide resolved
examples/gno.land/r/gov/dao/v2/prop4_filetest.gno Show resolved Hide resolved
gno.land/pkg/gnoland/param.go Show resolved Hide resolved
examples/gno.land/r/sys/params/params.gno Show resolved Hide resolved
examples/gno.land/r/sys/params/params.gno Show resolved Hide resolved
@zivkovicmilos zivkovicmilos merged commit 36cdadb into gnolang:master Nov 12, 2024
134 checks passed
thehowl
thehowl reviewed Nov 12, 2024
View reviewed changes
gno.land/pkg/gnoland/genesis.go
// each param is in the form: key.kind=value
content := osm.MustReadFile(path)

m := map[string] /*category*/ map[string] /*key*/ map[string] /*kind*/ interface{} /*value*/ {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

type Category, Key, Kind = string, string, string

map[Category]map[Key]map[Kind]interface{}

@zivkovicmilos zivkovicmilos mentioned this pull request Nov 15, 2024
Draft
6 tasks
@Kouteki Kouteki removed the in focus Core team is prioritizing this work label Nov 17, 2024
@Kouteki Kouteki mentioned this pull request Nov 21, 2024
Open
moul added a commit that referenced this pull request Dec 6, 2024
@moul @n0izn0iz
@MikaelVallenet @thehowl
feat: support custom VM domain (#2911)
ac899c8 
Introducing the concept of "ChainDomain," a local primary domain for
packages.

The next step, which will be another PR, is to ensure that we can launch
a gnoland/gnodev instance while importing a local folder or using a
genesis to preload packages from other domains. This will allow users to
add packages only to the primary domain while accessing packages from
multiple domains. The result will be a preview of the upcoming IBC era,
where a single chain can add packages only to its domain but can fetch
missing dependencies from other registered zones.

- [x] gnovm unaware of gno.land, just accepting valid domains
- [x] vmkeeper initialized with a domain
- [x] Stdlib to know the current primary domain + new std.ChainDomain
- [x] new unit tests around custom domains

Depends on #2910 
Depends on #3003
Blocks a new PR that will add multidomain support.
Related with
#2904 (comment)

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: n0izn0iz <[email protected]>
Co-authored-by: Mikael VALLENET <[email protected]>
Co-authored-by: Morgan <[email protected]>
omarsy pushed a commit to TERITORI/gno that referenced this pull request Dec 7, 2024
@moul @n0izn0iz
@MikaelVallenet @thehowl @omarsy
feat: support custom VM domain (gnolang#2911)
0282806 
Introducing the concept of "ChainDomain," a local primary domain for
packages.

The next step, which will be another PR, is to ensure that we can launch
a gnoland/gnodev instance while importing a local folder or using a
genesis to preload packages from other domains. This will allow users to
add packages only to the primary domain while accessing packages from
multiple domains. The result will be a preview of the upcoming IBC era,
where a single chain can add packages only to its domain but can fetch
missing dependencies from other registered zones.

- [x] gnovm unaware of gno.land, just accepting valid domains
- [x] vmkeeper initialized with a domain
- [x] Stdlib to know the current primary domain + new std.ChainDomain
- [x] new unit tests around custom domains

Depends on gnolang#2910
Depends on gnolang#3003
Blocks a new PR that will add multidomain support.
Related with
gnolang#2904 (comment)

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: n0izn0iz <[email protected]>
Co-authored-by: Mikael VALLENET <[email protected]>
Co-authored-by: Morgan <[email protected]>
Villaquiranm pushed a commit to Villaquiranm/gno that referenced this pull request Dec 9, 2024
@moul @n0izn0iz
@MikaelVallenet @thehowl @Villaquiranm
feat: support custom VM domain (gnolang#2911)
82829e4 
Introducing the concept of "ChainDomain," a local primary domain for
packages.

The next step, which will be another PR, is to ensure that we can launch
a gnoland/gnodev instance while importing a local folder or using a
genesis to preload packages from other domains. This will allow users to
add packages only to the primary domain while accessing packages from
multiple domains. The result will be a preview of the upcoming IBC era,
where a single chain can add packages only to its domain but can fetch
missing dependencies from other registered zones.

- [x] gnovm unaware of gno.land, just accepting valid domains
- [x] vmkeeper initialized with a domain
- [x] Stdlib to know the current primary domain + new std.ChainDomain
- [x] new unit tests around custom domains

Depends on gnolang#2910 
Depends on gnolang#3003
Blocks a new PR that will add multidomain support.
Related with
gnolang#2904 (comment)

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: n0izn0iz <[email protected]>
Co-authored-by: Mikael VALLENET <[email protected]>
Co-authored-by: Morgan <[email protected]>
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
@moul @thehowl @r3v4s
feat: add r/sys/params + params genesis support (gnolang#3003)
f127c41 
- [x] add `r/sys/params`
- [x] add `genesis/genesis_params.toml`
- [x] port some existing configurations
- [x] open issue: add LRU lazy caching with instant invalidation using a
transient store (gnolang#3023)

Depends on gnolang#2920 
Depends on gnolang#3003 (cherry-picked)
Blocking gnolang#2911

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: Morgan <[email protected]>
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
@moul @n0izn0iz
@MikaelVallenet @thehowl @r3v4s
feat: support custom VM domain (gnolang#2911)
9292ca3 
Introducing the concept of "ChainDomain," a local primary domain for
packages.

The next step, which will be another PR, is to ensure that we can launch
a gnoland/gnodev instance while importing a local folder or using a
genesis to preload packages from other domains. This will allow users to
add packages only to the primary domain while accessing packages from
multiple domains. The result will be a preview of the upcoming IBC era,
where a single chain can add packages only to its domain but can fetch
missing dependencies from other registered zones.

- [x] gnovm unaware of gno.land, just accepting valid domains
- [x] vmkeeper initialized with a domain
- [x] Stdlib to know the current primary domain + new std.ChainDomain
- [x] new unit tests around custom domains

Depends on gnolang#2910 
Depends on gnolang#3003
Blocks a new PR that will add multidomain support.
Related with
gnolang#2904 (comment)

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: n0izn0iz <[email protected]>
Co-authored-by: Mikael VALLENET <[email protected]>
Co-authored-by: Morgan <[email protected]>
albttx pushed a commit that referenced this pull request Jan 10, 2025
@moul @n0izn0iz
@MikaelVallenet @thehowl @albttx
feat: support custom VM domain (#2911)
8213475 
Introducing the concept of "ChainDomain," a local primary domain for
packages.

The next step, which will be another PR, is to ensure that we can launch
a gnoland/gnodev instance while importing a local folder or using a
genesis to preload packages from other domains. This will allow users to
add packages only to the primary domain while accessing packages from
multiple domains. The result will be a preview of the upcoming IBC era,
where a single chain can add packages only to its domain but can fetch
missing dependencies from other registered zones.

- [x] gnovm unaware of gno.land, just accepting valid domains
- [x] vmkeeper initialized with a domain
- [x] Stdlib to know the current primary domain + new std.ChainDomain
- [x] new unit tests around custom domains

Depends on #2910 
Depends on #3003
Blocks a new PR that will add multidomain support.
Related with
#2904 (comment)

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: n0izn0iz <[email protected]>
Co-authored-by: Mikael VALLENET <[email protected]>
Co-authored-by: Morgan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@thehowl thehowl thehowl left review comments

@gfanton gfanton gfanton approved these changes

@jaekwon jaekwon Awaiting requested review from jaekwon

Assignees

@zivkovicmilos zivkovicmilos

Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
💪 Bounties & Worx
Status: Done
😎 Manfred's Board
Status: ✅ Done
🧙‍♂️gno.land core team
Archived in project
Milestone
🚀 Mainnet beta launch
Development

Successfully merging this pull request may close these issues.
5 participants
@moul @thehowl @gfanton @zivkovicmilos @Kouteki