[dashboard] Use SCM Service (gRPC) #19101
Merged
+95
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
reviewed
Nov 21, 2023
mustard-mh
reviewed
Nov 21, 2023
15 tasks
mustard-mh
reviewed
Nov 21, 2023
AlexTugarev
force-pushed
the
at/scm-service-dashboard
branch
from
b92b9a9 to
b154839
Compare
AlexTugarev
force-pushed
the
at/scm-service
branch
from
254a607 to
54798af
Compare
AlexTugarev
force-pushed
the
at/scm-service-dashboard
branch
2 times, most recently
from
5e7f233 to
4dfd63e
Compare
AlexTugarev
force-pushed
the
at/scm-service
branch
from
54798af to
baaadc3
Compare
AlexTugarev
force-pushed
the
at/scm-service-dashboard
branch
from
4dfd63e to
1641a05
Compare
akosyakov
reviewed
Nov 22, 2023
components/dashboard/src/data/git-providers/search-repositories-query.ts
Show resolved
Hide resolved
|
I'm going to test it now with FF disabled, i.e. JSON-RPC. |
|
@AlexTugarev I added Updated: i guess it is expected because I still have |
|
JSON-RPC works well, I'm going to test now with FF on. |
akosyakov
approved these changes
Nov 22, 2023
AlexTugarev
force-pushed
the
at/scm-service-dashboard
branch
from
e122c8d to
8fbf988
Compare
|
Thanks for testing @akosyakov! 'Bumped the cache version. |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #19098
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at b92b9a9
Refactored the dashboard and the server to use a new
SCMServiceinterface for SCM-related operations instead of theGitpodServerinterface. Added Protobuf, gRPC, and Connect definitions and implementations for theSCMServiceinterface. Removed unused or deprecated parameters and interfaces from theGitpodServerinterface.Related Issue(s)
Fixes #
How to test
UIs affected by this PR, but we need to verify that they continue working as usual.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold