address review comments

gitpod-io · Nov 22, 2023 · 8fbf988 · 8fbf988
1 parent 1d59f0b
commit 8fbf988
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/components/dashboard/src/service/json-rpc-scm-client.ts b/components/dashboard/src/service/json-rpc-scm-client.ts
@@ -27,13 +27,9 @@ export class JsonRpcScmClient implements PromiseClient<typeof SCMService> {
             throw new ApplicationError(ErrorCodes.BAD_REQUEST, "host is required");
         }
         const response = new SearchSCMTokensResponse();
-        try {
-            const token = await getGitpodService().server.getToken({ host });
-            if (token) {
-                response.tokens.push(converter.toSCMToken(token));
-            }
-        } catch (error) {
-            throw new ApplicationError(ErrorCodes.NOT_FOUND, "token not found");
+        const token = await getGitpodService().server.getToken({ host });
+        if (token) {
+            response.tokens.push(converter.toSCMToken(token));
         }
         return response;
     }
@@ -53,7 +49,7 @@ export class JsonRpcScmClient implements PromiseClient<typeof SCMService> {
         });
         return new GuessTokenScopesResponse({
             message: response.message,
-            scopes: response.scopes,
+            scopes: response.scopes || [],
         });
     }