[db] Move towards sync deletion (away from PeriodicDeleter) - step I/II #18833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
geropl
commented
Sep 28, 2023
| name: "d_b_user_storage_resource", | ||
| primaryKeys: ["userId", "uri"], | ||
| timeColumn: "_lastModified", | ||
| deletionColumn: "deleted", |
There was a problem hiding this comment.
We don't use this table for years now... 🙈
svenefftinge
approved these changes
Sep 28, 2023
|
/unhold |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PeriodicDeleter is a leftover of the time we had multiple databases + db-sync, which forced us to have an async deletion mechanism. Since this is no longer true, we should move away from this pattern as it started to rot really badly.
It's step I/II, and defensively only switches to sync deletion for the entities that don't do that already. Column deletion is done in a 2nd step (#18826).
For details see the commits overview.
Summary generated by Copilot
🤖 Generated by Copilot at c7d19e6
This pull request refactors the database layer of the
gitpod-io/gitpodrepository to use hard deletion instead of soft deletion for several tables and entities. This simplifies the code, improves performance and maintainability, and avoids unnecessary data retention. It also removes the unuseddeletedcolumns and properties from thed_b_team,d_b_project,Project, andOrganizationtables and interfaces. It includes the corresponding migration files to apply the schema changes to the existing database.Related Issue(s)
Fixes EXP-718
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold