Move towards sync deletion (away from PeriodicDeleter) - step II/II

[geropl]

Description

Depends on - and follow-up to: #18833

Deletes all the columns that we are not using anymore.

Summary generated by Copilot

🤖 Generated by Copilot at 66cbbe5

This pull request removes the deleted column from various tables and entities in the components/gitpod-db module and replaces it with the markedDeleted column where applicable. It also drops some unused tables from the database schema. It adds migration scripts to apply these changes to the database. The purpose of this pull request is to simplify and update the database schema and the code that interacts with it.

Related Issue(s)

Fixes EXP-719

How to test

• check server logs, and verify that database-gc does execute without errors
• create an org, and successfully delete it right after

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

• 🏷️ Name - gpl-719-deleted-2
• 🔗 URL - gpl-719-deleted-2.preview.gitpod-dev.com/workspaces.
• 📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
• 📦 Version - gpl-719-deleted-2-gha.18120
• 🗒️ Logs - GCP Logs Explorer

Build Options

Build

• /werft with-werft
  Run the build with werft instead of GHA
• leeway-no-cache
• /werft no-test
  Run Leeway with --dont-test

Publish

• /werft publish-to-npm
• /werft publish-to-jb-marketplace

Installer

• analytics=segment
• with-dedicated-emulation
• workspace-feature-flags
  Add desired feature flags to the end of the line above, space separated

Preview Environment / Integration Tests

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-gce-vm
  If enabled this will create the environment on GCE infra
• with-integration-tests=all
  Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
• with-monitoring

/hold

[svenefftinge]

When we deploy, there might be a few entries in the DB that are marked but not deleted. We would need to make sure the periodic deleter runs once more before removing the logic around the deletionColumn

[geropl]

When we deploy, there might be a few entries in the DB that are marked but not deleted. We would need to make sure the periodic deleter runs once more before removing the logic around the deletionColumn

That's why I deployed the first part of this PR, which changed how we delete stuff (the writes), on Friday.

By now Cloud + all Dedicated instances received that version (commits), and should also executed the deleter often enough to cleanup the old stuff. This PR only deletes columns/tables we are not using anymore (except the Go changes which an oversight, but they are not used anywhere except tests...), and adjusts the reads/selects.

[geropl]

Just found an oversight, though: ALORIGTHM=INSTANT creeped back in 🙈 Will remove those.

[geropl]

Just found an oversight, though: ALORIGTHM=INSTANT creeped back in 🙈 Will remove those.

Done.

[geropl]

Thanks for the ✔️ !

I will hold this until tomorrow, so I can attend the rollout. 👍

[geropl]

/unhold