[WIP] Move towards sync deletion (away from PeriodicDeleter) - step II/II #18826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P) (#18794) * Update Platform Version of JetBrains Gateway Plugin (EAP) to 233.6745-EAP-CANDIDATE-SNAPSHOT * bump kotlin to `1.9.10` --------- Co-authored-by: Huiwen <[email protected]>
followup #18816
* [supervisor] Make UID/GID configurable * Support content initializer as env var * Make workspace runtime explicit * Make linux user configurable for Git operations * Don't assume /home/gitpod * Fix unittest * Fix wsdaemon
* [content-service] log the duration for download and extraction for S3 The DirectDownloader interface does not differentiate between downloading and extract tarbal...when youdownload, you also extract. https://github.com/gitpod-io/gitpod/blob/9a38b607055780fa7b2cd61c1379143d6c7b3715/components/content-service/pkg/storage/storage.go#L133 In the context of a prebuild initializer: https://github.com/gitpod-io/gitpod/blob/9a38b607055780fa7b2cd61c1379143d6c7b3715/components/content-service/pkg/initializer/prebuild.go#L69 When we Run, we do DownloadSnapshot: https://github.com/gitpod-io/gitpod/blob/9a38b607055780fa7b2cd61c1379143d6c7b3715/components/content-service/pkg/initializer/snapshot.go#L48 It does both operations: https://github.com/gitpod-io/gitpod/blob/9a38b607055780fa7b2cd61c1379143d6c7b3715/components/content-service/pkg/storage/s3.go#L290 Supervisor, which records initializer metrics, reads them from /workspace/.gitpod/ready file: https://github.com/gitpod-io/gitpod/blob/55414729fab00fa23888c1868579425907518a68/components/supervisor/pkg/supervisor/supervisor.go#L1639 * [content-service] denote when download is found
This times out in 100 seconds, and is causing failures for builds in main. Maybe it needs more time.
geropl
force-pushed
the
gpl/716-deleted
branch
from
5032c03 to
a623617
Compare
14 tasks
geropl
force-pushed
the
gpl/719-deleted-2
branch
from
cbc18b7 to
5568b46
Compare
geropl
force-pushed
the
gpl/716-deleted
branch
from
a623617 to
15ca4bd
Compare
14 tasks
* Add subassembly service API * Make workspacekit image configurable
…II (#18833) * [db] Tables: remove entries without deletionColumn (not used anymore) * [db] DBAuthProviderEntry: Switch to sync deletion * [db] DBTokenEntry: Switch to sync deletion * [db] DBTeamMembership: Switch to sync deletion * [db] DBUserStorageResource: remove from periodic deleter * [db] DBGitpodToken: Switch to sync deletion * [db] DBProjectUsage: Switch to sync deletion * [db] DBUserSSHPublicKey: Switch to sync deletion
….fgaRelationshipsVersion (#18838) * [db] Add User.fgaRelationshipsVersion * [server] Use User.fgaRelationshipsVersion
Co-authored-by: roboquat <[email protected]>
* update code commit * bump up code stable version
* adding searchRepositories method w/ github impl * fix a few things and add bbs impl for searchRepos * integrate searchRepositories in RepositoryFinder * adjusting loading indicators * cleanup * wrap repository search behind feature flag * Changing queries for github repo search * fix enabled to use debounced value * fix org filters * drop variables for query * fixing encoding
Co-authored-by: roboquat <[email protected]>
* implementing searchRepositories * implement searchRepos for BBS * limit fields * remove fields * adding gitlab searchRepos * remove gitlab searchRepos - not working will do in a followup * wrap calls w/ asyncBatch to limit concurrency
* Update `marketplace.json` * Add exts * update * snyk * 💄 --------- Co-authored-by: Jean Pierre <[email protected]>
geropl
force-pushed
the
gpl/719-deleted-2
branch
from
5568b46 to
66cbbe5
Compare
|
Outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on - and follow-up to: #18825
Deletes all the columns that we are not using anymore.
Summary generated by Copilot
🤖 Generated by Copilot at cbc18b7
This pull request removes the
deletedcolumn from various tables and entities in the Gitpod database, as well as the obsoleted_b_user_storage_resourcetable. This is part of a refactoring effort to simplify the database layer of the Gitpod application and improve its performance. It also updates theProjectinterface and theDBProjectentity to match the project management feature in Gitpod. It includes several migration files to apply the schema changes to the database.Related Issue(s)
Fixes EXP-719
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold