Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [server] Remove api.maySetTimeout (+ code cleanup in User- + EntitlementService) #18744

Closed
wants to merge 2 commits into from

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 19, 2023

Description

Depends on: #18743

Summary generated by Copilot

🤖 Generated by Copilot at c2eac6b

Refactored and enforced entitlement checks for workspace timeout settings based on organization ID. Changed the maySetTimeout method signature in the GitpodServer interface and the GitpodServerImpl class to make the opts parameter mandatory and remove the organizationId property. Updated the EntitlementServiceUBP class to simplify the subscription and entitlement logic.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl geropl force-pushed the gpl/orgid-timeout-2 branch from 8af83ac to 8e91584 Compare September 21, 2023 14:47
@geropl geropl changed the title [WIP] [server] EntitlementService.maySetTimeout: Make organizationId mandatory [WIP] [server] Remove api.maySetTimeout (+ code cleanup in User- + EntitlementService) Sep 21, 2023
@geropl geropl closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants