Remove logic for determining transfer syntax #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psavery
force-pushed
the
wsidicom-updates
branch
from
7a6920a to
586519a
Compare
|
Since wsidicom no longer supports Python3.8, we'll need to only support DICOMweb for Python > 3.8. We'll make that change in this PR too. |
psavery
force-pushed
the
wsidicom-updates
branch
2 times, most recently
from
ce60c95 to
83bc440
Compare
psavery
commented
Dec 3, 2023
psavery
force-pushed
the
wsidicom-updates
branch
from
83bc440 to
705d595
Compare
psavery
force-pushed
the
wsidicom-updates
branch
2 times, most recently
from
60e09c3 to
c684457
Compare
wsidicom now determines the transfer syntax automatically, as of version 0.14.0, so we don't need to do this anymore. wsidicom also supports more transfer syntaxes as well, so the list of transfer syntaxes we had are not complete now either. Just remove this logic and let wsidicom take care of it. Signed-off-by: Patrick Avery <[email protected]>
Unfortunately, the newer versions of wsidicom, which we need to support certain data formats for DICOMweb, require Python 3.9 or greater. So we are going to only allow the DICOMweb plugin to be loaded for Python >= 3.9. The regular DICOM reader will still work with wsidicom for Python 3.8, but only the DICOMweb part will not be loaded. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
wsidicom-updates
branch
from
c684457 to
56a6e9c
Compare
Signed-off-by: Patrick Avery <[email protected]>
manthey
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wsidicom now determines the transfer syntax automatically, as of version 0.14.0, so we don't need to do this anymore.
wsidicom also supports more transfer syntaxes as well, so the list of transfer syntaxes we had are not complete now either. Just remove this logic and let wsidicom take care of it.
wsidicom now has optional dependencies: imagecodecs and pylibjpeg-rle. If we install those optional dependencies, it adds support for several more transfer syntaxes. Those are found here.
Fixes: #1308