Only support Python >= 3.9 for DICOMweb

Unfortunately, the newer versions of wsidicom, which we need to support certain data formats for DICOMweb, require Python 3.9 or greater. So we are going to only allow the DICOMweb plugin to be loaded for Python >= 3.9. The regular DICOM reader will still work with wsidicom for Python 3.8, but only the DICOMweb part will not be loaded. Signed-off-by: Patrick Avery <[email protected]>
girder · Dec 4, 2023 · 705d595 · 705d595
1 parent d5af348
commit 705d595
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/sources/dicom/large_image_source_dicom/girder_plugin.py b/sources/dicom/large_image_source_dicom/girder_plugin.py
@@ -1,3 +1,5 @@
+import sys
+
 from girder.plugin import GirderPlugin
 
 from . import assetstore
@@ -8,4 +10,8 @@ class DICOMwebPlugin(GirderPlugin):
     CLIENT_SOURCE_PATH = 'web_client'
 
     def load(self, info):
+        if sys.version_info < (3, 9):
+            # We do not support python less than 3.9 for this plugin
+            return
+
         assetstore.load(info)
diff --git a/sources/dicom/test_dicom/test_web_client.py b/sources/dicom/test_dicom/test_web_client.py
@@ -1,7 +1,13 @@
 import os
+import sys
 
 import pytest
 
+# We support Python 3.9 and greater for DICOMweb
+pytestmark = [
+    pytest.mark.skipif(sys.version_info < (3, 9), reason='requires python3.9 or higher'),
+]
+
 
 @pytest.mark.girder()
 @pytest.mark.girder_client()

diff --git a/test/test_source_dicomweb.py b/test/test_source_dicomweb.py
@@ -1,7 +1,14 @@
+import sys
+
 import pytest
 
 from . import utilities
 
+# We support Python 3.9 and greater for DICOMweb
+pytestmark = [
+    pytest.mark.skipif(sys.version_info < (3, 9), reason='requires python3.9 or higher'),
+]
+
 
 @pytest.mark.plugin('large_image_source_dicom')
 def testTilesFromDICOMweb():