Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polexes for vsphere cloud provider app (it contains 4 sub-charts) #292

Closed
wants to merge 2 commits into from

Conversation

jkremser
Copy link
Contributor

moved from this original pr: giantswarm/cloud-provider-vsphere-app#59 that was also creating the required CRD

Checklist

  • Update changelog in CHANGELOG.md.
  • Make sure values.yaml and values.schema.json are valid.

Copy link
Contributor

@stone-z stone-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but overall looks good

@@ -61,6 +61,9 @@ policyExceptions:
# Deploy a PolicyException for chart-operator (required for Giant Swarm clusters).
enableChartOperatorPolex: true

# Deploy PolicyExceptions for vsphere provider - cpi, kubevip, etc. (required for Giant Swarm clusters).
enableVsphereProviderPolex: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this would be enabled on MCs through config -- is there a way to enable it also for CAPV workload clusters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be an option in default apps, I am actually working on adding Kyverno to WCs for vsphere - https://github.com/giantswarm/default-apps-vsphere/pull/140/files#diff-0708195cf15ea7b702d1af55719e20899a250b27e9dca539819647317b672144R34-R41 And I've just found your comment on the issue about security bundle repo :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw. it's set to false because other provider don't care about vsphere related things, but we can make it true your call, true would be actually much easier for multi-provider environments (like wepa)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question was because I don't know enough about our current CAPI config setup to know what's involved in enabling it in WCs if it isn't done here.
Obviously I'd prefer not to deploy exceptions which aren't needed, so if it's possible to enable the exception through some provider-specific means, that's nicer IMO (so leaving this false).

@fhielpos
Copy link
Member

Is this still needed? Can we update/merge/close this?

@fhielpos
Copy link
Member

@giantswarm/team-rocket , I will close this one too. If you ever need this feel free to open it again.

@fhielpos fhielpos closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants