-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSS + use kustomize from binary not from kubectl #62
Conversation
seccompProfile: | ||
type: RuntimeDefault | ||
|
||
containerSecurityContext: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who uses these? Subcharts use global
section and their own section like vsphere-csi-driver
above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also leftover, it was used for install-crd job, so removing. The nameOverride
options for individual sub-charts are necessary here btw. because it's used to put correct labels on pods + are used as name of the pods. And kubevip pods (cloud provider, kubevip running as service LB and kubevip running as HA for control-plane) had the same prefix so it wasn't possible to distinguish between them in the polex. These are then re-used here.
@@ -15,6 +15,28 @@ | |||
} | |||
} | |||
}, | |||
"crdInstall": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this left-over?
Signed-off-by: Jirka Kremser <[email protected]>
@@ -37,3 +41,19 @@ kube-vip-cloud-provider: | |||
image: | |||
repository: docker.io/giantswarm/kube-vip-cloud-provider | |||
tag: "v0.0.4" | |||
nameOverride: kube-vip-cloud-provider | |||
|
|||
vsphere-csi-driver: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't have this at the root level. I would have it at the subchart level to keep root values clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
pr w/ exceptions is here: giantswarm/kyverno-app#292
Checklist
values.yaml
andvalues.schema.json
are valid.