Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSS + use kustomize from binary not from kubectl #62

Merged
merged 1 commit into from
Oct 12, 2023
Merged

PSS + use kustomize from binary not from kubectl #62

merged 1 commit into from
Oct 12, 2023

Conversation

jkremser
Copy link
Contributor

@jkremser jkremser commented Oct 10, 2023

pr w/ exceptions is here: giantswarm/kyverno-app#292

Checklist

  • Update changelog in CHANGELOG.md.
  • Make sure values.yaml and values.schema.json are valid.

@jkremser jkremser requested a review from a team as a code owner October 10, 2023 12:28
@jkremser jkremser mentioned this pull request Oct 10, 2023
Closed
seccompProfile:
type: RuntimeDefault

containerSecurityContext:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who uses these? Subcharts use global section and their own section like vsphere-csi-driver above.

Copy link
Contributor Author

@jkremser jkremser Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also leftover, it was used for install-crd job, so removing. The nameOverride options for individual sub-charts are necessary here btw. because it's used to put correct labels on pods + are used as name of the pods. And kubevip pods (cloud provider, kubevip running as service LB and kubevip running as HA for control-plane) had the same prefix so it wasn't possible to distinguish between them in the polex. These are then re-used here.

@@ -15,6 +15,28 @@
}
}
},
"crdInstall": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this left-over?

@@ -37,3 +41,19 @@ kube-vip-cloud-provider:
image:
repository: docker.io/giantswarm/kube-vip-cloud-provider
tag: "v0.0.4"
nameOverride: kube-vip-cloud-provider

vsphere-csi-driver:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have this at the root level. I would have it at the subchart level to keep root values clean.

Copy link
Contributor

@erkanerol erkanerol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@jkremser jkremser merged commit 59f1a33 into main Oct 12, 2023
@jkremser jkremser deleted the pss-2 branch October 12, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants