Add test case for #4167, marked as an expected failure. #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
issue-4167-test-case
branch
from
908289a to
f81c3c5
Compare
cwfitzgerald
approved these changes
Sep 23, 2023
jimblandy
force-pushed
the
issue-4167-test-case
branch
from
f81c3c5 to
11b5fe8
Compare
|
I think this is what you asked for?? Do we really have to skip every test that might panic on wasm? |
|
Yeah we do - there's not a lot of good ways around this as we aren't using our own test harness on wasm. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case for #4167, marked as an expected failure with a comment referring to the issue.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.