Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wgpu): Raise validation error instead of panicking in get_bind_group_layout. #6280

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

BGR360
Copy link
Contributor

@BGR360 BGR360 commented Sep 15, 2024

Connections
Fixes #4167.

Depends on #6275.

Description

Testing
I've removed the expect-fail decoration from the existing test added in #4168, and added three more tests to cover the remaining cases.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Sorry, something went wrong.

Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nical
Copy link
Contributor

nical commented Sep 18, 2024

I just saw that the PR is still marked as WIP, are there other changes you are planning to make?

@BGR360
Copy link
Contributor Author

BGR360 commented Sep 18, 2024

There were documentation changes I wanted to make. Also I need to update CHANGELOG. I ran out of time before I put up the PR. I have more time now, I'll update the PR.

@BGR360 BGR360 force-pushed the issue-4167-validate-bgl branch from 9ce0403 to 2784795 Compare September 18, 2024 21:01
@BGR360 BGR360 marked this pull request as ready for review September 18, 2024 21:02
@BGR360 BGR360 requested a review from a team as a code owner September 18, 2024 21:02
@BGR360 BGR360 requested a review from nical September 18, 2024 21:02
@nical nical merged commit 9f85f8a into gfx-rs:trunk Sep 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComputePipeline::get_bind_group_layout panics if the pipeline's module is invalid
2 participants