Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.py: fix issues with os.walk() and bytes/string encoding #66

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Staudey
Copy link
Member

@Staudey Staudey commented Jun 17, 2024

generator.next() is no longer valid in Python 3

bytes object has to be decoded to string before use

This fixes build issues for the third party repo scripts for "Android Studio", "Insync"; and, slightly more importantly, pisi itself.

Part of getsolus/3rd-party#78

generator.next() is no longer valid in Python 3

bytes object has to be decoded to string before use

Signed-off-by: Thomas Staudinger <[email protected]>
@Staudey Staudey changed the title build.py: fix os.walk() fix issues with os.walk() and bytes/string encoding Jun 17, 2024
@Staudey Staudey changed the title fix issues with os.walk() and bytes/string encoding build.py: fix issues with os.walk() and bytes/string encoding Jun 17, 2024
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

@ermo ermo merged commit 1a3b8c1 into getsolus:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants