Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed test to no longer use public microsoft symbol server. #1519

Merged
merged 2 commits into from
Sep 18, 2024
+12 −11
Merged

Changed test to no longer use public microsoft symbol server. #1519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32aa0d2
Updated test_no_dif_candidates to not make use of the Microsoft symbo…
tobias-wilfert Sep 16, 2024
69251ff
Changed the test to make use of an existing pdb file instead of addin…
tobias-wilfert Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...c/endpoints/snapshots/symbolicator__endpoints__symbolicate__tests__no_dif_candidates.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ stacktraces:
frames:
- status: symbolicated
original_index: 0
instruction_addr: "0x749e8630"
instruction_addr: "0x749d37f2"
package: "C:\\Windows\\System32\\kernel32.dll"
symbol: BaseThreadInitThunk
sym_addr: "0x749e8630"
function: BaseThreadInitThunk
symbol: memcpy
sym_addr: "0x749d37f2"
function: memcpy
lineno: 0
modules:
- debug_status: found
Expand All @@ -24,8 +24,7 @@ modules:
arch: x86
type: pe
code_file: "C:\\Windows\\System32\\kernel32.dll"
debug_id: ff9f9f78-41db-88f0-cded-a9e1e9bff3b5-1
debug_file: "C:\\Windows\\System32\\wkernel32.pdb"
debug_id: 3249d99d-0c40-4931-8610-f4e4fb0b6936-1
debug_file: "C:\\Windows\\System32\\crash.pdb"
image_addr: "0x749d0000"
image_size: 851968

10 changes: 6 additions & 4 deletions crates/symbolicator/src/endpoints/symbolicate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,20 +165,22 @@ mod tests {
let payload = r#"{
"stacktraces": [{
"registers": {"eip": "0x0000000001509530"},
"frames": [{"instruction_addr": "0x749e8630"}]
"frames": [{"instruction_addr": "0x749d37f2"}]
}],
"modules": [{
"type": "pe",
"debug_id": "ff9f9f78-41db-88f0-cded-a9e1e9bff3b5-1",
"debug_id": "3249d99d-0c40-4931-8610-f4e4fb0b6936-1",
"code_file": "C:\\Windows\\System32\\kernel32.dll",
"debug_file": "C:\\Windows\\System32\\wkernel32.pdb",
"debug_file": "C:\\Windows\\System32\\crash.pdb",
"image_addr": "0x749d0000",
"image_size": 851968
}],
"sources": []
}"#;
let mut payload: SymbolicationRequestBody = serde_json::from_str(payload).unwrap();
payload.sources = Some(vec![test::microsoft_symsrv()]);

let (_srv, source) = test::symbol_server();
payload.sources = Some(vec![source]);

let response = Client::new()
.post(server.url("/symbolicate"))
Expand Down
Loading