Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed test to no longer use public microsoft symbol server. #1519

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Changed test to no longer use public microsoft symbol server. #1519

merged 2 commits into from
Sep 18, 2024

Conversation

tobias-wilfert
Copy link
Member

@tobias-wilfert tobias-wilfert commented Sep 16, 2024 •
edited by olksdr
Loading

Addressing #1004 by changing test to make use of local fixture instead of public microsoft symbol server.

fix: #1004

@tobias-wilfert tobias-wilfert self-assigned this Sep 16, 2024
loewenheim
loewenheim approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's still testing the thing it's supposed to be but without Microsoft dependency.

@tobias-wilfert tobias-wilfert merged commit 9f9dc81 into master Sep 18, 2024
13 checks passed
@tobias-wilfert tobias-wilfert deleted the test-fixture branch September 18, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loewenheim loewenheim loewenheim approved these changes

Assignees

@tobias-wilfert tobias-wilfert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop needlessly using the public microsoft symbol server in tests
2 participants
@tobias-wilfert @loewenheim