Create a tracing layer doing JSON output and Sentry at once
#1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also consolidates all the usage sites and removes unused feature flags
Using composition to chain the JSON output and the Sentry layer means that both layers are capturing span attributes, duplicating that work. This pretty much copy-pasted the code of both these layers and combines them, thus avoiding doing all the `SpanAttribute` capturing twice.
loewenheim
reviewed
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using composition to chain the JSON output and the Sentry layer means that both layers are capturing span attributes, duplicating that work.
This pretty much copy-pasted the code of both these layers and combines them, thus avoiding doing all the
SpanAttributecapturing twice.TBH, I don’t think this might be fully worth it, as copy-pasting all this code over looks really horrible :-(