Micro-optimize Span Field recording #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `&'static str` as the key - Reuse a thread local buffer to format `Debug` fields This duplicates the `FieldVisitor`, as other parts of the integration still expect `String` keys.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #642 +/- ##
==========================================
- Coverage 73.33% 73.14% -0.19%
==========================================
Files 62 62
Lines 7563 7603 +40
==========================================
+ Hits 5546 5561 +15
- Misses 2017 2042 +25 |
loewenheim
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&'static stras the keyDebugfieldsThis duplicates the
FieldVisitor, as other parts of the integration still expectStringkeys.This extracts the good part of getsentry/symbolicator#1382