chore(dashboards): Add analytics for dashboards view and favourites #83766
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
gggritso
reviewed
Jan 21, 2025
Comment on lines
51
to
52
| // TODO(nikki): may not need this one | ||
| 'dashboards_manage.count_favourites': {count: number; user_id: string}; |
There was a problem hiding this comment.
In that case, might as well not include it, IMO!
Suggested change
| // TODO(nikki): may not need this one | |
| 'dashboards_manage.count_favourites': {count: number; user_id: string}; |
| @@ -144,9 +150,12 @@ export const dashboardsEventMap: Record<DashboardsEventKey, string | null> = { | |||
| 'dashboards_views.widget_library.opened': 'Dashboards2: Add Widget Library opened', | |||
| 'dashboards_manage.search': 'Dashboards Manager: Search', | |||
| 'dashboards_manage.change_sort': 'Dashboards Manager: Sort By Changed', | |||
| 'dashboards_manage.change_view_type': 'Dashboards Manager: View Type Toggled', | |||
| 'dashboards_manage.count_favourites': 'Dashboards Manager: Count Favourites', | |||
There was a problem hiding this comment.
Suggested change
| 'dashboards_manage.count_favourites': 'Dashboards Manager: Count Favourites', |
| 'dashboards_manage.create.start': {}; | ||
| 'dashboards_manage.delete': {dashboard_id: number; view_type: DashboardsLayout}; | ||
| 'dashboards_manage.duplicate': {dashboard_id: number; view_type: DashboardsLayout}; | ||
| 'dashboards_manage.favourite': {dashboard_id: string; favourited: boolean}; |
There was a problem hiding this comment.
Suggested change
| 'dashboards_manage.favourite': {dashboard_id: string; favourited: boolean}; | |
| 'dashboards_manage.favorite': {dashboard_id: string; favorited: boolean}; |
🇨🇦 👮🏻
There was a problem hiding this comment.
Might be confusing that an "unfavorite" event has the same name! Maybe toggle_favorite would be better?
| 'dashboards_manage.create.start': 'Dashboards Manager: Dashboard Create Started', | ||
| 'dashboards_manage.delete': 'Dashboards Manager: Dashboard Deleted', | ||
| 'dashboards_manage.duplicate': 'Dashboards Manager: Dashboard Duplicated', | ||
| 'dashboards_manage.favourite': 'Dashboards Manager: Dashboard Favourited', |
There was a problem hiding this comment.
Suggested change
| 'dashboards_manage.favourite': 'Dashboards Manager: Dashboard Favourited', | |
| 'dashboards_manage.favorite': 'Dashboards Manager: Dashboard Favorited', |
gggritso
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding analytics to:
Still need to figure out how to add analytics to view how many dashboards a user has favourited...
Contributes to #83742