chore(dashboards): Add analytics for dashboards view and favourites (#…

…83766) Adding analytics to: - see if users toggle between table and grid view + see which view they switch to - view interaction between the favourite button Still need to figure out how to add analytics to view how many dashboards a user has favourited... Contributes to #83742
getsentry · Jan 22, 2025 · 9a02e57 · 9a02e57
1 parent e1a158a
commit 9a02e57
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 1 deletion.
diff --git a/static/app/utils/analytics/dashboardsAnalyticsEvents.tsx b/static/app/utils/analytics/dashboardsAnalyticsEvents.tsx
@@ -45,6 +45,9 @@ export type DashboardsEventParameters = {
   'dashboards_manage.change_sort': {
     sort: string;
   };
+  'dashboards_manage.change_view_type': {
+    view_type: DashboardsLayout;
+  };
   'dashboards_manage.create.start': {};
   'dashboards_manage.delete': {dashboard_id: number; view_type: DashboardsLayout};
   'dashboards_manage.duplicate': {dashboard_id: number; view_type: DashboardsLayout};
@@ -61,6 +64,7 @@ export type DashboardsEventParameters = {
   'dashboards_manage.templates.toggle': {
     show_templates: boolean;
   };
+  'dashboards_manage.toggle_favorite': {dashboard_id: string; favorited: boolean};
   'dashboards_views.open_in_discover.opened': {
     widget_type: string;
   };
@@ -144,13 +148,15 @@ export const dashboardsEventMap: Record<DashboardsEventKey, string | null> = {
   'dashboards_views.widget_library.opened': 'Dashboards2: Add Widget Library opened',
   'dashboards_manage.search': 'Dashboards Manager: Search',
   'dashboards_manage.change_sort': 'Dashboards Manager: Sort By Changed',
+  'dashboards_manage.change_view_type': 'Dashboards Manager: View Type Toggled',
   'dashboards_manage.create.start': 'Dashboards Manager: Dashboard Create Started',
   'dashboards_manage.delete': 'Dashboards Manager: Dashboard Deleted',
   'dashboards_manage.duplicate': 'Dashboards Manager: Dashboard Duplicated',
   'dashboards_manage.paginate': 'Dashboards Manager: Paginate',
   'dashboards_manage.templates.toggle': 'Dashboards Manager: Template Toggle Changed',
   'dashboards_manage.templates.add': 'Dashboards Manager: Template Added',
   'dashboards_manage.templates.preview': 'Dashboards Manager: Template Previewed',
+  'dashboards_manage.toggle_favorite': 'Dashboards Manager: Dashboard Favorite Toggled',
   'dashboards_views.widget_viewer.edit': 'Widget Viewer: Edit Widget Modal Opened',
   'dashboards_views.widget_viewer.open': 'Widget Viewer: Opened',
   'dashboards_views.widget_viewer.open_source':

diff --git a/static/app/views/dashboards/controls.tsx b/static/app/views/dashboards/controls.tsx
@@ -220,6 +220,11 @@ function Controls({
                         dashboard.id,
                         !isFavorited
                       );
+                      trackAnalytics('dashboards_manage.toggle_favorite', {
+                        organization,
+                        dashboard_id: dashboard.id,
+                        favorited: !isFavorited,
+                      });
                     } catch (error) {
                       // If the api call fails, revert the state
                       setIsFavorited(isFavorited);

diff --git a/static/app/views/dashboards/manage/dashboardGrid.tsx b/static/app/views/dashboards/manage/dashboardGrid.tsx
@@ -106,6 +106,11 @@ function DashboardGrid({
     try {
       await updateDashboardFavorite(api, organization.slug, dashboard.id, isFavorited);
       onDashboardsChange();
+      trackAnalytics('dashboards_manage.toggle_favorite', {
+        organization,
+        dashboard_id: dashboard.id,
+        favorited: isFavorited,
+      });
     } catch (error) {
       throw error;
     }

diff --git a/static/app/views/dashboards/manage/dashboardTable.tsx b/static/app/views/dashboards/manage/dashboardTable.tsx
@@ -98,6 +98,11 @@ function FavoriteButton({
           setFavorited(!favorited);
           await updateDashboardFavorite(api, organization.slug, dashboardId, !favorited);
           onDashboardsChange();
+          trackAnalytics('dashboards_manage.toggle_favorite', {
+            organization,
+            dashboard_id: dashboardId,
+            favorited: !favorited,
+          });
         } catch (error) {
           // If the api call fails, revert the state
           setFavorited(favorited);

diff --git a/static/app/views/dashboards/manage/index.tsx b/static/app/views/dashboards/manage/index.tsx
@@ -264,7 +264,13 @@ function ManageDashboards() {
         />
         <Feature features={'organizations:dashboards-table-view'}>
           <SegmentedControl<DashboardsLayout>
-            onChange={setDashboardsLayout}
+            onChange={newValue => {
+              setDashboardsLayout(newValue);
+              trackAnalytics('dashboards_manage.change_view_type', {
+                organization,
+                view_type: newValue,
+              });
+            }}
             size="md"
             value={dashboardsLayout}
             aria-label={t('Layout Control')}