-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(workflow_engine): Add legacy_notification_product
column to workflow_engine.Action
#82117
Conversation
This PR has a migration; here is the generated SQL for --
-- Moved action.required field to pending deletion state
--
-- (no-op)
--
-- Add field legacy_notification_product to action
--
ALTER TABLE "workflow_engine_action" ADD COLUMN "legacy_notification_product" text NULL; |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82117 +/- ##
==========================================
+ Coverage 80.36% 80.38% +0.01%
==========================================
Files 7276 7277 +1
Lines 321475 321259 -216
Branches 20966 20966
==========================================
- Hits 258366 258256 -110
+ Misses 62701 62595 -106
Partials 408 408 |
6169992
to
2b2c12b
Compare
This PR has a migration; here is the generated SQL for --
-- Add field legacy_notification_type to action
--
ALTER TABLE "workflow_engine_action" ADD COLUMN "legacy_notification_type" text NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, i can add additional action types when i get to this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema change looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration lgtm
Description
While designing the NotificationActionHandler, we've run into a number of methods that are tightly coupled to the legacy product models. This will allow us to easily switch between the two registries and simplify which actions are available in the UI.
Also removes the
NOTIFICATION
generalized type in favor of specific types. This will allow us to more easily search / sort by these columns.