Skip to content

Commit

Permalink
Remove NOTIFICATION type
Browse files Browse the repository at this point in the history
  • Loading branch information
saponifi3d committed Dec 14, 2024
1 parent 7895d54 commit 6169992
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions tests/sentry/workflow_engine/models/test_action.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class TestAction(TestCase):
def setUp(self):
self.mock_event = Mock(spec=GroupEvent)
self.mock_detector = Mock(name="detector")
self.action = Action(type=Action.Type.NOTIFICATION)
self.action = Action(type=Action.Type.SLACK)

def test_get_handler_notification_type(self):
with patch("sentry.workflow_engine.registry.action_handler_registry.get") as mock_get:
Expand All @@ -22,7 +22,7 @@ def test_get_handler_notification_type(self):

handler = self.action.get_handler()

mock_get.assert_called_once_with(Action.Type.NOTIFICATION)
mock_get.assert_called_once_with(Action.Type.SLACK)
assert handler == mock_handler

def test_get_handler_webhook_type(self):
Expand All @@ -49,7 +49,7 @@ def test_get_handler_unregistered_type(self):
self.action.get_handler()

# Verify the registry was queried with the correct action type
mock_get.assert_called_once_with(Action.Type.NOTIFICATION)
mock_get.assert_called_once_with(Action.Type.SLACK)

def test_trigger_calls_handler_execute(self):
mock_handler = Mock(spec=ActionHandler)
Expand Down
2 changes: 1 addition & 1 deletion tests/sentry/workflow_engine/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def create_workflow_action(
action_group = self.create_data_condition_group(logic_type="any-short")

action = self.create_action(
type=Action.Type.NOTIFICATION,
type=Action.Type.SLACK,
data={"message": "test"},
**kwargs,
)
Expand Down

0 comments on commit 6169992

Please sign in to comment.