fix(releases): Clearer guidance for release names #81963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81963 +/- ##
===========================================
+ Coverage 66.88% 80.36% +13.48%
===========================================
Files 7272 7273 +1
Lines 321099 321189 +90
Branches 20955 20932 -23
===========================================
+ Hits 214758 258133 +43375
+ Misses 105927 62651 -43276
+ Partials 414 405 -9 |
scttcper
approved these changes
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears up some confusion around valid release names. Addresses #16012.
Appended from checking out the code here: https://github.com/getsentry/sentry/blob/master/src/sentry/models/release.py#L307