-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode(?) Sentry release name #16012
Comments
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
I suspect this a result of creating a release prior to us enforcing some restrictions that were not communicated on the API. If this is still an issue for users I'll be happy to reopen/address it, but for now I've put together a PR to communicate those restrictions here. We do restrict slashes, and that is not set to change at the moment. |
Clears up some confusion around valid release names. Addresses #16012. Appended from checking out the code here: https://github.com/getsentry/sentry/blob/master/src/sentry/models/release.py#L307
Important Details
How are you running Sentry?
Description
I created a release named 2019-11-04/1, when I try to visit the releases url on sentry.io (sentry.io/organizations/perfectstay/releases/2019-11-04%F4/?project=182xxxx) the following error message is displayed : "This release may not be in your selected project: React"
When I inspect the devtools network panel the GET request returned à 404 not found.
I then decided to replace the / with a "@" and now it is working fine.
Steps to Reproduce
What you expected to happen
Access the page
Possible Solution
Maybe check the decoding part server side ? Or just forbid forward slashes for releases names.
By the way, thank you a lot for your time and for this amazing tool. Love you all. I hope i'll be able to contribute some code this year (:
UPDATE : https://github.com/getsentry/sentry/blob/master/src/sentry/api/endpoints/organization_release_details.py
I think it's in this file, never did some python but I'll try to look at it this week
The text was updated successfully, but these errors were encountered: