-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci): Use codecov GH action instead of bash script #32959
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ca50f58
build(ci): Use codecov GH action instead of bash script
billyvg e608943
add coverage for relay tests
billyvg 8c19efa
Merge branch 'master' into build/ci/use-codecov-github-action-2
billyvg 87dc7de
debug
billyvg ffb4f9d
use file glob
billyvg 2c86ce9
unset NODE_OPTIONS?
billyvg 3b5dc0c
...
billyvg 0581ec2
typo
billyvg b1b76b3
no coverage for frontend flag for acceptance tests
billyvg 121655a
Merge branch 'master' into build/ci/use-codecov-github-action-2
billyvg ea11d17
Merge branch 'master' into build/ci/use-codecov-github-action-2
billyvg 5299e5b
add comment
billyvg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,26 @@ | ||
name: 'Sentry Artifacts' | ||
description: 'Handles uploading coverage/test artifacts to codecov' | ||
|
||
inputs: | ||
files: | ||
description: "Path to coverage file(s) - comma separated for multiple files" | ||
default: ".artifacts/*.coverage.xml" | ||
required: true | ||
type: | ||
description: "The type of change (frontend, backend)" | ||
default: "backend" | ||
required: false | ||
|
||
runs: | ||
using: "composite" | ||
steps: | ||
- name: Upload to codecov | ||
shell: bash | ||
run: | | ||
coverage_files=$(ls .artifacts/*coverage.xml || true) | ||
if [[ -n "$coverage_files" || -f .artifacts/coverage/cobertura-coverage.xml ]]; then | ||
bash <(curl -s https://codecov.io/bash) -v | ||
fi | ||
uses: codecov/codecov-action@v2 | ||
env: | ||
# This is because of a bug in codecov's uploader | ||
# See: https://github.com/codecov/uploader/issues/475 | ||
NODE_OPTIONS: "" | ||
with: | ||
flags: ${{ inputs.type }} | ||
files: ${{ inputs.files }} | ||
verbose: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I assume this is intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I initially refactored these paths and noticed relay wasn't outputting coverage stats.