build(ci): Use codecov GH action instead of bash script #32959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a GH Action instead of bash script. The bash script has been deprecated. See https://github.com/codecov/codecov-action
armenzg
reviewed
Mar 28, 2022
.github/actions/artifacts/action.yml
Outdated
| fi | ||
| uses: codecov/codecov-action@v2 | ||
| env: | ||
| NODE_OPTIONS: "" |
armenzg
reviewed
Mar 28, 2022
| @@ -161,7 +161,7 @@ test-plugins: | |||
|
|
|||
| test-relay-integration: | |||
| @echo "--> Running Relay integration tests" | |||
| pytest tests/relay_integration -vv | |||
| pytest tests/relay_integration -vv --cov . --cov-report="xml:.artifacts/relay.coverage.xml" --junit-xml=".artifacts/relay.junit.xml" | |||
There was a problem hiding this comment.
Can I assume this is intentional?
There was a problem hiding this comment.
Yeah I initially refactored these paths and noticed relay wasn't outputting coverage stats.
armenzg
approved these changes
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a GH Action instead of bash script. The bash script has been deprecated. See https://github.com/codecov/codecov-action
This does NOT fix the spiky reporting of coverage (which I believe is due to flakey tests, eg, 3 of 4 test instances fail, but we still report 3 of them to codecov.
Note, due to a bug in codecov, we have to unset
NODE_OPTIONS