Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): Add scraping_attempts field #2575

Merged
merged 8 commits into from
Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
- Write span tags to `span.sentry_tags`. ([#2555](https://github.com/getsentry/relay/pull/2555))
- Use JSON instead of MsgPack for Kafka spans. ([#2556](https://github.com/getsentry/relay/pull/2556))
- Add `profile_id` to spans. ([#2569](https://github.com/getsentry/relay/pull/2569))
- Add `scraping_attempts` field to the event schema. ([#2575](https://github.com/getsentry/relay/pull/2575))

## 23.9.1

Expand Down
4 changes: 4 additions & 0 deletions py/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

- Add `scraping_attempts` field to the event schema. ([#2575](https://github.com/getsentry/relay/pull/2575))

## 0.8.31

- Add `Reservoir` variant to `SamplingRule`. ([#2550](https://github.com/getsentry/relay/pull/2550))
Expand Down
5 changes: 5 additions & 0 deletions relay-event-schema/src/protocol/event.rs
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,11 @@ pub struct Event {
#[metastructure(omit_from_schema)] // we only document error events for now
pub breakdowns: Annotated<Breakdowns>,

/// Information about attempts to scrape a JS source or sourcemap file from the web.
/// This field is populated by sentry.
#[metastructure(omit_from_schema)] // not part of external schema
pub scraping_attempts: Annotated<Object<Value>>,
jjbayer marked this conversation as resolved.
Show resolved Hide resolved

/// Internal ingestion and processing metrics.
///
/// This value should not be ingested and will be overwritten by the store normalizer.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
source: relay-general/src/pii/processor.rs
source: relay-pii/src/processor.rs
expression: "&data"
---
Event {
Expand Down Expand Up @@ -105,6 +105,7 @@ Event {
spans: ~,
measurements: ~,
breakdowns: ~,
scraping_attempts: ~,
_metrics: ~,
other: {},
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
source: relay-general/src/pii/processor.rs
source: relay-pii/src/processor.rs
expression: "&data"
---
Event {
Expand Down Expand Up @@ -105,6 +105,7 @@ Event {
spans: ~,
measurements: ~,
breakdowns: ~,
scraping_attempts: ~,
_metrics: ~,
other: {},
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
source: relay-general/src/pii/processor.rs
source: relay-pii/src/processor.rs
expression: "&data"
---
Event {
Expand Down Expand Up @@ -86,6 +86,7 @@ Event {
spans: ~,
measurements: ~,
breakdowns: ~,
scraping_attempts: ~,
_metrics: ~,
other: {},
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
source: relay-general/src/pii/processor.rs
source: relay-pii/src/processor.rs
expression: "&data"
---
Event {
Expand Down Expand Up @@ -116,6 +116,7 @@ Event {
spans: ~,
measurements: ~,
breakdowns: ~,
scraping_attempts: ~,
_metrics: ~,
other: {},
}
Loading