feat(protocol): Add scraping_attempts field #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
approved these changes
Oct 6, 2023
loewenheim
reviewed
Oct 6, 2023
loewenheim
approved these changes
Oct 6, 2023
iker-barriocanal
approved these changes
Oct 9, 2023
| /// Information about attempts to scrape a JS source or sourcemap file from the web. | ||
| /// This field is populated by sentry. | ||
| #[metastructure(omit_from_schema)] // not part of external schema | ||
| pub scraping_attempts: Annotated<Array<Value>>, |
There was a problem hiding this comment.
Should we make this a Value instead of Array instead?
There was a problem hiding this comment.
I think this is a good call. Then Relay dies not even have to be updated if the sentry-side schema ever changed to an object to include more metadata, for example. Updated now.
iker-barriocanal
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getsentry/sentry#57461 introduced a new top-level field on the event that is only written by sentry. To prevent errors when the event passes through normalization after writing
scraping_attempts, make sure that the new field is part of the schema known by (lib)relay.